Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the specification validation workflow #3351

Merged
merged 1 commit into from
Sep 15, 2023
Merged

update the specification validation workflow #3351

merged 1 commit into from
Sep 15, 2023

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Sep 15, 2023 •
edited
Loading

Update the specification validation workflow:

  • always validate the specification - try to create the spec pdf
  • only perform the firebase upload step if the triggering event is a PR merge

This should address the issue where automated dependabot PRs to update our github actions deps fail CI (ala #3316).

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew devoncarew merged commit b19bf29 into main Sep 15, 2023
@devoncarew devoncarew deleted the spec_workflow branch September 15, 2023 18:01
@devoncarew
Copy link
Member Author

Hmm, well, this skipped the upload phase for the PR - which is good - but also skipped it on the merge to main, which is bad.

Screenshot 2023-09-15 at 11 05 30 AM

This will need some more work -

devoncarew added a commit that referenced this pull request Sep 15, 2023
@devoncarew
Update spec.yml
729edf4 
Fix the condition for running the publish spec step (a follow up to #3351).
@devoncarew devoncarew mentioned this pull request Sep 15, 2023
Merged
1 task
devoncarew added a commit that referenced this pull request Sep 15, 2023
@devoncarew
Update spec.yml (#3353)
976a151 
Fix the condition for running the publish spec step (a follow up to #3351).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

@mit-mit mit-mit Awaiting requested review from mit-mit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devoncarew @jakemac53